Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 1.2.30 #271

Merged
merged 1 commit into from
Sep 6, 2024
Merged

Release 1.2.30 #271

merged 1 commit into from
Sep 6, 2024

Conversation

jkotanchik-SB
Copy link
Contributor

@jkotanchik-SB jkotanchik-SB commented Sep 6, 2024 •
edited
Loading

MADiE PR

Jira Ticket: MAT-7639
(Optional) Related Tickets:

Summary

Release updates to DateTimeField.

All Submissions

  • This PR has the JIRA linked.
  • Required tests are included.
  • No extemporaneous files are included (i.e Complied files or testing results).
  • This PR is merging into the correct branch.
  • All Documentation needed for this PR is Complete (or noted in a TODO or other Ticket).
  • Any breaking changes or failing automations are noted by placing a comment on this PR.

DevSecOps

If there is a question if this PR has a security or infrastructure impact, please contact the Security or DevOps engineer assigned to this project to discuss it further.

  • This PR has NO significant security impact (i.e Changing auth methods, Adding a new user type, Adding a required but vulnerable package).
  • All CDN/Web dependencies are hosted internally (i.e MADiE-Root Repo).

Reviewers

By Approving this PR you are attesting to the following:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose.
  • The tests appropriately test the new code, including edge cases.
  • If you have any concerns they are brought up either to the developer assigned, security engineer, or leads.

@jkotanchik-SB jkotanchik-SB requested a review from a team as a code owner September 6, 2024 13:56
@jkotanchik-SB jkotanchik-SB self-assigned this Sep 6, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 6, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.36%. Comparing base (e9070d5) to head (88b8b5b).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #271   +/-   ##
=======================================
  Coverage   94.36%   94.36%           
=======================================
  Files          34       34           
  Lines         586      586           
  Branches      213      213           
=======================================
  Hits          553      553           
  Misses         32       32           
  Partials        1        1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jkotanchik-SB jkotanchik-SB merged commit cfa4525 into main Sep 6, 2024
7 checks passed
@jkotanchik-SB jkotanchik-SB deleted the feature/mat-7639-release branch September 6, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adongare adongare adongare approved these changes

@chubert-sb chubert-sb chubert-sb approved these changes

Assignees

@jkotanchik-SB jkotanchik-SB

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jkotanchik-SB @adongare @chubert-sb